Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Relative url support in OAuthFlow Object #71

Closed
PierrePrimot opened this issue Mar 19, 2020 · 3 comments
Closed

Relative url support in OAuthFlow Object #71

PierrePrimot opened this issue Mar 19, 2020 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@PierrePrimot
Copy link

Describe the bug

Relative URLs are not allowed in the authorizationUrl field of the OAuth Flow Object.

Expected behavior

The specification indicates that

Relative References in URLs
Unless specified otherwise, all properties that are URLs MAY be relative references as defined by RFC3986. Relative references are resolved using the URLs defined in the Server Object as a Base URI.

The authorization URL to be used for this flow. This MUST be in the form of a URL.

As there is nothing special about this URL, I guess this field (and others) should be allowed to use relative paths.

What do you think about it ?

@PierrePrimot PierrePrimot added the bug Something isn't working label Mar 19, 2020
@llfbandit llfbandit added this to the 0.8 milestone Mar 19, 2020
@llfbandit
Copy link
Contributor

llfbandit commented Mar 19, 2020

Hi and welcome,

You're right, this needs to be addressed. Unfortunately, as first thought, this can lead to skip url validation on URL fields as I can't concat it directly to server URL description because of potential parameter variables. Maybe as URI only? I'll digg into it to see if it is enough just after the current work I'm on.

Thanks for the report.

@llfbandit
Copy link
Contributor

Hi,
can you confirm the fix in latest 0.8-SNAPSHOT?

FYI, this fix has been extended to other models too (license, contact, ...).

@PierrePrimot
Copy link
Author

Hello,

The fix is working perfectly in my case, thank you very much ! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants