Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use maven wrapper (mvnw) in Git pre-commit hook #539

Closed
westse opened this issue Jun 29, 2023 · 0 comments · Fixed by #540
Closed

Use maven wrapper (mvnw) in Git pre-commit hook #539

westse opened this issue Jun 29, 2023 · 0 comments · Fixed by #540
Labels
enhancement
Milestone
2.1.0

Comments

@westse
Copy link
Contributor

westse commented Jun 29, 2023

The root pom.xml uses githook-maven-plugin to install a Git pre-commit hook to enforce formatting by running a formatter via the mvn command. Instead this should use the Maven wrapper (./mvnw), otherwise the mvn command will fail if it is not on the classpath, or could use an incorrect Maven version.
@joschi joschi linked a pull request Jun 30, 2023 that will close this issue
Use Maven wrapper in pre-commit hook #540
Merged
@joschi joschi mentioned this issue Jun 30, 2023
Merged
@joschi joschi added this to the 2.1.0 milestone Jun 30, 2023
joschi pushed a commit that referenced this issue Jun 30, 2023
@westse
Use Maven wrapper in pre-commit hook (#540)
e3cedbd 
Closes #539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Use Maven wrapper in pre-commit hook westse/openapi-diff
2 participants
@joschi @westse