Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should openapi-diff-core.jar be including logback.xml? #638

Closed
Blackbaud-JasonBodnar opened this issue Mar 21, 2024 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@Blackbaud-JasonBodnar
Copy link

Not sure if this is a bug or something we're doing wrong. But after upgrading to spring boot 3 our application no longer uses our logback-spring.xml. Stepping through the spring boot code that initializes logging I see that it's finding a logback.xml and the only one I found in the classpath resources is from openapi-diff-core.jar.

If I change our build.gradle from:

implementation "org.openapitools.openapidiff:openapi-diff-core:2.1.0-beta.8"

to:

compileOnly "org.openapitools.openapidiff:openapi-diff-core:2.1.0-beta.8"

Our logback-spring.xml is picked up and used. Of course, our app no longer runs :-(

So, should the jar file include logback.xml? Or are we doing something wrong?

@joschi joschi closed this as completed in c88cf5e Mar 21, 2024
@joschi joschi added this to the 2.1.0 milestone Mar 21, 2024
@joschi joschi added the bug label Mar 21, 2024
@joschi joschi self-assigned this Mar 21, 2024
@joschi
Copy link
Collaborator

joschi commented Mar 21, 2024

@Blackbaud-JasonBodnar Thanks for reporting this! You're absolutely correct and the Logback configuration shouldn't have been a part of the openapi-diff-core artifact.

@Blackbaud-JasonBodnar
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants