Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart-dio] Fix parameter generation problems #10061

Merged

Conversation

kuhnroyal
Copy link
Contributor

  • fix parameter with list of MultipartFile being generated as single MultipartFile
  • generate serializer factories for all container params, not only body params
  • fix compilation errors when skipFormModel=false

Related issues

We have nothing in the samples for these things so we need some people to test this.
@ahmednfwela maybe you can try?

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CC @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)

* fix parameter with list of `MultipartFile` being generated as single `MultipartFile`
* generate serializer factories for all container params, not only body params
* fix compilation errors when `skipFormModel=false`
@wing328 wing328 added this to the 5.2.1 milestone Aug 2, 2021
@kuhnroyal
Copy link
Contributor Author

Anyone care to review or tests this?

@wing328 wing328 merged commit ccd23ec into OpenAPITools:master Aug 4, 2021
@kuhnroyal kuhnroyal deleted the dart-dio/multipart-form-params branch August 5, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment