Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing from scriptName to x-codegen-script-name to fix dockerfile #10594

Merged
merged 1 commit into from Oct 16, 2021

Conversation

jeeftor
Copy link
Contributor

@jeeftor jeeftor commented Oct 13, 2021

This is a PR to fix the issue with the Bash Code generator not making valid docker files - see issue: #10589

The mustache template is looking for scriptName which is not set - however x-codegen-script-name is set so I've modified the template to use the set variable

PR checklist

  • [x ] Read the contribution guidelines.
  • [ x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • [ x] File the PR against the correct branch: master (5.3.0), 6.0.x
  • [ x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

This targets Bash
@frol (2017/07) @bkryza (2017/08) @kenjones-cisco (2017/09)

…ile correctly because scriptName isn't being set
@wing328
Copy link
Member

wing328 commented Oct 16, 2021

@jeeftor thanks for the fix, which looks good to me. I'll update the samples in another commit after merging this PR into master.

@wing328 wing328 merged commit fc7c6d8 into OpenAPITools:master Oct 16, 2021
@wing328 wing328 changed the title Changing from scriptName to x-codegen-script-name will render dockerf… Changing from scriptName to x-codegen-script-name to fix dockerfile Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants