Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Perl client header params #11713

Merged
merged 3 commits into from Feb 25, 2022
Merged

Fix Perl client header params #11713

merged 3 commits into from Feb 25, 2022

Conversation

7474
Copy link
Contributor

@7474 7474 commented Feb 25, 2022

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

The following error occurred when using the DELETE method.

Not a HASH reference at /app/local/lib/perl5/HTTP/Headers.pm line 160.

Matched the header settings of the DELETE method with GET and HEAD.
I also deleted unreferenced variables.

@wing328 @yue9944882

@wing328
Copy link
Member

wing328 commented Feb 25, 2022

@7474 thanks for the PR. Can you please fix the merge conflicts when you've time? PM via Slack if you need help.

@wing328 wing328 changed the title Fix perl client header params Fix Perl client header params Feb 25, 2022
@wing328
Copy link
Member

wing328 commented Feb 25, 2022

Tested locally and the result is good. Thanks for the PR.

@wing328 wing328 merged commit aa63ea0 into OpenAPITools:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants