[PYTHON] GetItem not working for Client generated allOf model and broken since 5.2.0 #12239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stances while doing the deserialization of the data.
Earlier the Python SDK code was using get_var_name_to_model_instances function which was adding var name to model instances that contain it. So <class 'openapi_client.model.stream_options_all_of'> will not part of mapping in self._var_name_to_model_instances for variable name stream_options.
Now with the latest Python SDK code following is the way through which var_name_to_model_instances is created:
for prop_name in model_args:
if prop_name not in discarded_args:
var_name_to_model_instances[prop_name] = [self] + composed_instances
Now as we can see that the var_name_to_model_instances is populated with self and composed_instance which will also contain stream_options_all_of as a composed instance and there will be no check that if stream_options is present in composed_instances or not.
As there is no attribute_mapping found for stream_options in stream_options_all_of, the type for stream_options will be treated as dict for mapping stream_options_all_of as mentioned by @Chekov2k.
So what I suggest is the following code:
for prop_name in model_args:
if prop_name not in discarded_args:
var_name_to_model_instances[prop_name] = [self] + list(
filter(
lambda x: prop_name in x.openapi_types, composed_instances))
This way we can check if the property name is present in that composed instance or not. If it's okay for @spacether I can raise a PR for this.
…into getiem_all_of_bug
Added samples, test cases to validate all_of schema.
the-akhil-nair
force-pushed
the
getiem_all_of_bug
branch
from
9efa6b2
to
a58caae
Compare
…into getiem_all_of_bug # Conflicts: # samples/openapi3/client/petstore/python/.openapi-generator/FILES # samples/openapi3/client/petstore/python/README.md # samples/openapi3/client/petstore/python/petstore_api/models/__init__.py
Updated docs and samples.
…into getiem_all_of_bug
Updated test cases, docs and samples.
spacether
reviewed
May 28, 2022
| var_name_to_model_instances[prop_name] = [self] + composed_instances | ||
| var_name_to_model_instances[prop_name] = [self] + list( | ||
| filter( | ||
| lambda x: prop_name in x.openapi_types, composed_instances)) |
There was a problem hiding this comment.
So technically in every instance of the payload prop_name should be present but this code did work before so I am okay with this being merged back in.
the-akhil-nair
force-pushed
the
getiem_all_of_bug
branch
from
709e71f
to
a333e98
Compare
spacether
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The issue is due to the creation of
self._var_name_to_model_instanceswhile doing the deserialization of the data.Earlier the Python SDK code was using
get_var_name_to_model_instancesfunction which was adding var name to model instances that contain it.Now the
var_name_to_model_instancesis populated withself and composed_instanceand there will be no check if a variable name is present in composed_instances or not.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator bypassing the relevant config(s) as an argument to the script, for example,
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x@taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11) @wing328
Fixes #11299