Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-qt-client] Fix warnings #14056

Merged
merged 2 commits into from Nov 20, 2022

Conversation

MartinDelille
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @ravinikam @stkrwork @etherealjoy @muttleyxd

@wing328
Copy link
Member

wing328 commented Nov 18, 2022

can you please update the samples?

 void OauthCredentials::setVariables(QString tokenUrl, QString scope, QString clientId, QString clientSecret){
@@ -206,7 +206,7 @@ void OauthPassword::link()
 
 void OauthPassword::unlink()
 {
-    disconnect(this,0,0,0);
+    disconnect(this, nullptr, nullptr, nullptr);
 }
 
 void OauthPassword::setVariables(QString tokenUrl, QString scope, QString clientId, QString clientSecret, QString username, QString password){
Perform git status
HEAD detached at pull/14056/merge
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   samples/client/petstore/cpp-qt/client/PFXOauth.cpp

no changes added to commit (use "git add" and/or "git commit -a")

ref: https://github.com/OpenAPITools/openapi-generator/actions/runs/3490844364/jobs/5842865742

@MartinDelille
Copy link
Contributor Author

Sorry! Long time I didn't contribute and I just forgot! I would have check the issue in the CI anyway! 😄

@wing328
Copy link
Member

wing328 commented Nov 20, 2022

@MartinDelille No problem :) Always appreciate your contributions 👍

Tested locally and the result is good:

QDEBUG : UserApiTests::loginUserTest() "{\"code\":200,\"type\":\"unknown\",\"message\":\"logged in user session:1668931788895\"}"
PASS   : UserApiTests::loginUserTest()
PASS   : UserApiTests::logoutUserTest()
QDEBUG : UserApiTests::updateUserTest() got a request body
PASS   : UserApiTests::updateUserTest()
PASS   : UserApiTests::cleanupTestCase()
Totals: 10 passed, 0 failed, 0 skipped, 0 blacklisted, 121ms
********* Finished testing of UserApiTests *********
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  3.797 s
[INFO] Finished at: 2022-11-20T00:09:49-08:00
[INFO] ------------------------------------------------------------------------

@wing328 wing328 merged commit 2a7b3cd into OpenAPITools:master Nov 20, 2022
@wing328 wing328 added this to the 6.3.0 milestone Nov 20, 2022
@MartinDelille MartinDelille deleted the cpp-qt-client-fix-warning branch November 20, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants