Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Fix api_error.mustache to initialize message-only errors properly #14264

Merged

Conversation

ykitamura-mdsol
Copy link
Contributor

When generating message-only errors (e.g. ApiError.new('Connection failed')), the @message instance variable is not set so the message method returns the default message:

if @message.nil?
msg = "Error message: the server returns an error"

Screenshot 2022-12-15 at 9 31 33 AM

With this PR (setting the @message instance variable), the message method returns the expected message:

Screenshot 2022-12-15 at 9 31 45 AM

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

@wing328
Copy link
Member

wing328 commented Dec 17, 2022

thanks for the PR.

tests passed via https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator?branch=ykitamura-mdsol-fix%2Fruby_api_error_message

@wing328 wing328 merged commit 6800905 into OpenAPITools:master Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants