Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Adds a sha256 configuration option to hs2019 #14467

Merged
merged 19 commits into from Jan 16, 2023

Conversation

vvb
Copy link
Contributor

@vvb vvb commented Jan 16, 2023

Currently, the HS2019 signing scheme defaults to sha512. This may not suit the needs of some systems that use hs2019 with sha256. This PR allows for users to use sha256 with hs2019, while not changing the current default behaviour.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

code-lucidal58 and others added 18 commits November 2, 2020 23:13
update with upstream master
Merge upstream code to master
pulling in the python set-item fix from master
pull in golang restrict read-only props changes from upstream
@vvb vvb changed the title Hs2019 sha256 [Go] Adds a sha256 configuration option to hs2019 Jan 16, 2023
@vvb
Copy link
Contributor Author

vvb commented Jan 16, 2023

@wing328
Copy link
Member

wing328 commented Jan 16, 2023

Unknown circleci failure. Let me close and reopen the to see if the issue goes away.

@wing328
Copy link
Member

wing328 commented Jan 16, 2023

Go tests passed via CircleCI node 2.

failure of other nodes are not related to this change.

@wing328 wing328 merged commit 9f50293 into OpenAPITools:master Jan 16, 2023
@vvb vvb deleted the hs2019-sha256 branch October 11, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants