Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[erlang-client] fix URL paths #14988

Merged
merged 1 commit into from Mar 21, 2023
Merged

Conversation

dweinstein
Copy link
Contributor

@dweinstein dweinstein commented Mar 17, 2023

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

* integers parameters in URL did not work as expected
* so now, if the parameter is an integer, we convert it to binary before
  passing to `hackney_url:make_url/3`
@dweinstein
Copy link
Contributor Author

1> petstore_pet_api:get_pet_by_id(#{}, 5, #{cfg => #{host => <<"https://petstore.swagger.io">>}}).
{ok,#{category => #{id => 0,name => <<"string">>},
      id => 5,name => <<"doggie">>,
      photoUrls => [<<"string">>],
      status => <<"string">>,
      tags => [#{id => 0,name => <<"string">>}]},
    #{headers =>
          [{<<"Date">>,<<"Fri, 17 Mar 2023 21:50:29 GMT">>},
           {<<"Content-Type">>,<<"application/json">>},
           {<<"Transfer-Encoding">>,<<"chunked">>},
           {<<"Connection">>,<<"keep-alive">>},
           {<<"Access-Control-Allow-Origin">>,<<"*">>},
           {<<"Access-Control-Allow-Methods">>,
            <<"GET, POST, DELETE, PUT">>},
           {<<"Access-Control-Allow-Headers">>,
            <<"Content-Type, api_key, Authorization">>},
           {<<"Server">>,<<"Jetty(9.2.9.v20150224)">>}],
      status => 200}}

@dweinstein dweinstein marked this pull request as ready for review March 17, 2023 22:47
5.3.0-SNAPSHOT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like your fix is not based on the latest master. i'll update the samples after merging this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 hrm I thought I had branched off of the latest master. is there something I should normally do when switching to the master branch to make sure the correct version is used normally?

@wing328
Copy link
Member

wing328 commented Mar 18, 2023

FYI. @tsloughter (2017/11) @jfacorro (2018/10) @robertoaloi (2018/10)

@wing328
Copy link
Member

wing328 commented Mar 21, 2023

tests with updated samples passed via #15016

@wing328 wing328 merged commit fc91fca into OpenAPITools:master Mar 21, 2023
7 of 8 checks passed
@wing328
Copy link
Member

wing328 commented Mar 21, 2023

samples updated via 38d9dc1

@dweinstein dweinstein deleted the patch-3 branch March 22, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants