Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Use getType in ModelUtils #18577

Merged
merged 3 commits into from
May 7, 2024
Merged

[refactor] Use getType in ModelUtils #18577

merged 3 commits into from
May 7, 2024

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 6, 2024

[refactor] Use getType in ModelUtils to handle both openapi 3.0 and 3.1 spec

related: #18034

to close #18291

fyi @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 changed the title Use getType in model utils [refactor] Use getType in ModelUtils May 6, 2024
@wing328 wing328 added this to the 7.6.0 milestone May 6, 2024
@wing328 wing328 marked this pull request as ready for review May 7, 2024 09:08
@wing328 wing328 closed this May 7, 2024
@wing328 wing328 reopened this May 7, 2024
@wing328 wing328 merged commit 9929d35 into master May 7, 2024
64 checks passed
@wing328 wing328 deleted the refactor-type branch May 7, 2024 10:05
renatomameli pushed a commit to renatomameli/openapi-generator that referenced this pull request May 17, 2024
* use getType in model utils

* add tests

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 3.1.0 Missing type for array when using allOf and $ref
1 participant