Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Kotlin-retrofit2-gson-coroutines CollectionsFormat.CSVParams default value is set to arrayListOf() #18864

Open
5 of 6 tasks
fvlahov opened this issue Jun 5, 2024 · 0 comments

Comments

@fvlahov
Copy link

fvlahov commented Jun 5, 2024

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

Open api generator where the code generated gives parameter of type CSVParams gives wrong default implementation, it should create the CSVParams class but instead it is @Query("sort") sort: CSVParams? = arrayListOf("date:desc")

openapi-generator version

7.6.0

OpenAPI declaration file content or url
    SortSchema:
      type: array
      description: |
        ...
      default: [ 'date:desc' ]
      items:
        type: string
        pattern: '^(date|name|popularity|trend)(:(asc|desc))?$'
      example: [ 'date:desc', 'name' ]
Generation Details
        generatorName = "kotlin"
        inputSpec = "$rootDir/data/src/main/assets/openapi/${spec.value}"
        outputDir = "$buildDir/generated/openapi"
        configOptions = [
                dateLibrary         : "java17",
                library             : "jvm-retrofit2",
                serializationLibrary: "gson",
                useCoroutines       : "true"
        ]
        nameMappings = [
                "identifier": "id"
        ]
        modelNamePrefix = "Api"
        apiNameSuffix = "Api"
        generateModelTests = false
        generateApiTests = false
Steps to reproduce
  • Generate retrofit API and classes with openApiGenerate {}
  • Build fails due to compilation error
Related issues/PRs
Suggest a fix

Default value of CSVParams should create an instance of CSVParams class instead of ArrayList

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant