Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Generator: Crystal client generator #86

Closed
wing328 opened this issue May 17, 2018 · 10 comments
Closed

New Generator: Crystal client generator #86

wing328 opened this issue May 17, 2018 · 10 comments

Comments

@wing328
Copy link
Member

wing328 commented May 17, 2018

If anyone is interested in contributing a Crystal client generator, please reply to let us know. We can use reverse engineering to create the Crystal generator and template based on a functional Crystal Petstore client similar to what we did before for PowerShell, Lua, etc.

Please reply to let us know if you want to work on this. Thanks.

@wing328 wing328 added this to the 3.0.0 milestone May 17, 2018
@wing328 wing328 modified the milestones: 3.0.0, 3.0.1 Jun 1, 2018
@wing328 wing328 removed this from the 3.0.1 milestone Jun 11, 2018
@ddcprg
Copy link

ddcprg commented Nov 10, 2019

Hi, anyone working on this yet? I may be able to help

@wing328
Copy link
Member Author

wing328 commented Nov 11, 2019

@ddcprg I don't think anyone has started on this yet.

Do you mind PM'ing me on Slack so that we can formulate a plan?

https://join.slack.com/t/openapi-generator/shared_invite/enQtNzAyNDMyOTU0OTE1LTY5ZDBiNDI5NzI5ZjQ1Y2E5OWVjMjZkYzY1ZGM2MWQ4YWFjMzcyNDY5MGI4NjQxNDBiMTlmZTc5NjY2ZTQ5MGM

@wing328
Copy link
Member Author

wing328 commented Nov 13, 2019

Similar to how some other generators (e.g. R, Lua, PowerShell) are created, we will use the reverse engineering process to create the Crystal client generator.

  1. create Crystal petstore client samples (implemented at least 2 endpoints to start with: getPetById, addPet)
  2. file a PR to put the client under samples/client/petstore/crystal
  3. reverse engineer the templates and the generator (Java class)
  4. test the auto-generated code and revise the generator, templates
  5. alpha/beta release

Petstore spec:

@ndbroadbent
Copy link
Contributor

ndbroadbent commented Dec 2, 2019

Hello! My company has just decided to support the Crystal language. We use openapi-generator, so I would love to work on this and release a Crystal API client for my service. I think it shouldn't be too difficult since the syntax is so similar to Ruby.

(I just realized that I should be supporting openapi-generator as well, so I've also set up a monthly donation on opencollect!)

I'm not sure how much time I can dedicate to this, but I can probably work on it during evenings and weekends. It will also be a great opportunity to learn more about the Crystal language. (I think Crystal would also be the perfect language for building a compiled CLI tool that people can use to interact with my API.)

@wing328
Copy link
Member Author

wing328 commented Dec 4, 2019

@ndbroadbent thanks for becoming a sponsor of openapi-generator.

Looking forward to your PR for the Crystal client generator. If you need help, please let me know.

@ddcprg
Copy link

ddcprg commented May 11, 2020

@ndbroadbent do you still want to go ahead and contribute this?

@ndbroadbent
Copy link
Contributor

Hi @ddcprg, sorry unfortunately I didn't have time to start working on this! Anyone else can please feel free to take over if you might be interested

@ddcprg
Copy link

ddcprg commented May 14, 2020

hi @ndbroadbent no problem, I'll try to take over then although is busy times for me as well

@wing328
Copy link
Member Author

wing328 commented Jan 4, 2021

I've filed #8304 to start with. add_pet and get_pet_by_id work and are tested as part of the CI.

It's not perfect. There's still a lot needs to be done and I'll create a TODO list later.

For the time being, please try it out and let me know if you've any feedback.

@wing328
Copy link
Member Author

wing328 commented Jan 7, 2021

Closed via #8304

@wing328 wing328 closed this as completed Jan 7, 2021
nilskuhn pushed a commit to nilskuhn/openapi-generator that referenced this issue Apr 6, 2023
feat(core): add opencollective to to show sponsorship message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants