[dart][dart-dio-next] Improve support for file uploads #9542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add support for filenames in multipart requests by using `MultipartFile` from dio directly * add support for binary/file body data * fixes OpenAPITools#6671 * fixes OpenAPITools#9079
jaumard
reviewed
May 21, 2021
...api-generator/src/main/java/org/openapitools/codegen/languages/DartDioNextClientCodegen.java
Outdated
Show resolved
Hide resolved
kuhnroyal
force-pushed
the
dart-dio/file-support
branch
from
36f5260
to
a3519b9
Compare
|
Finally, very much needed. |
agilob
reviewed
May 21, 2021
...api-generator/src/main/java/org/openapitools/codegen/languages/DartDioNextClientCodegen.java
Show resolved
Hide resolved
agilob
reviewed
May 21, 2021
samples/openapi3/client/petstore/dart-dio-next/petstore_client_lib_fake/doc/PetApi.md
Show resolved
Hide resolved
kuhnroyal
commented
May 21, 2021
| @@ -36,7 +36,7 @@ void main() { | |||
| 'int64': '9223372036854775807', | |||
| 'date': '2020-08-11', | |||
| 'dateTime': '2020-08-11T12:30:55.123Z', | |||
| 'binary': "Instance of 'MultipartFile'", | |||
| 'binary': '[0, 1, 2, 3, 4, 5]', | |||
There was a problem hiding this comment.
Not sure this makes sense to send over the wire like this, but better than before in any case.
agilob
approved these changes
May 21, 2021
|
@kuhnroyal please resolve the merge conflicts when you've time. Thanks. |
|
CI failure not related to this change. |
premiumitsolution
pushed a commit
to premiumitsolution/openapi-generator
that referenced
this pull request
May 26, 2021
…9542) * [dart][dart-dio] Improve support for file uploads * add support for filenames in multipart requests by using `MultipartFile` from dio directly * add support for binary/file body data * fixes OpenAPITools#6671 * fixes OpenAPITools#9079 * Add and fix tests * Only use MultipartFile for body/multipart parameters * Fix test * Actually fix tests
|
I am currently using 5.2.0, but I found that the change to support MultipartFile does not seem to take effect at all. I checked the generated template and found that there was no change at all!!! |
|
dart-dio-next |
|
This should work with |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultipartFilefrom dio directly@jaumard @ayushin This should fix your linked issues.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.xCC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)