Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp][tiny] rename generator, update samples #9560

Merged
merged 3 commits into from May 25, 2021
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 24, 2021

  • rename genreator
  • minor code format change

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)

@wing328 wing328 mentioned this pull request May 24, 2021
5 tasks
Copy link
Contributor

@AndersSpringborg AndersSpringborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements! It's nice to get feedback from someone, with so much system knowledge 😃
I don't see anything that would change the behavior of the generated code :)

@AndersSpringborg AndersSpringborg mentioned this pull request May 25, 2021
5 tasks
@wing328 wing328 marked this pull request as ready for review May 25, 2021 15:48
@wing328 wing328 added this to the 5.2.0 milestone May 25, 2021
@wing328 wing328 merged commit ae430a8 into master May 25, 2021
@wing328 wing328 deleted the Arduino-enhance branch May 25, 2021 15:55
@wing328 wing328 mentioned this pull request May 25, 2021
5 tasks
premiumitsolution pushed a commit to premiumitsolution/openapi-generator that referenced this pull request May 26, 2021
* rename generator, update samples

* add doc

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants