go test ./go/... does not work for me. Does it work for you?

[sjmudd]

For PRs you ask us to check if go test works. For me the current code does not work.
That is I see:

[user@myhost ~/src/orchestrator/src/github.com/github/orchestrator]$ go test ./go/...
?   	github.com/github/orchestrator/go/agent	[no test files]
ok  	github.com/github/orchestrator/go/app	0.017s
?   	github.com/github/orchestrator/go/attributes	[no test files]
?   	github.com/github/orchestrator/go/cmd/orchestrator	[no test files]
ok  	github.com/github/orchestrator/go/collection	0.017s
ok  	github.com/github/orchestrator/go/config	0.020s
?   	github.com/github/orchestrator/go/db	[no test files]
?   	github.com/github/orchestrator/go/discovery	[no test files]
ok  	github.com/github/orchestrator/go/http	0.029s
ok  	github.com/github/orchestrator/go/inst	0.023s
?   	github.com/github/orchestrator/go/logic	[no test files]
?   	github.com/github/orchestrator/go/metrics	[no test files]
?   	github.com/github/orchestrator/go/metrics/query	[no test files]
?   	github.com/github/orchestrator/go/os	[no test files]
?   	github.com/github/orchestrator/go/process	[no test files]
?   	github.com/github/orchestrator/go/remote	[no test files]
2017-04-30 23:29:54 INFO MutualTLS requested, client certificates will be verified
--- FAIL: TestNewTLSConfig (0.00s)
	ssl_test.go:40: Could not create new TLS config: No certificates parsed
--- FAIL: TestVerify (0.00s)
	ssl_test.go:94: x509: RSA key missing NULL parameters
2017-04-30 23:29:54 INFO Decrypted /var/folders/v5/6pdpvnbn7pg9h41pnbsr1klscmtspv/T/ssl_test488963850 successfully
--- FAIL: TestAppendKeyPair (0.01s)
	ssl_test.go:154: Failed to append certificate and key to tls config: x509: RSA key missing NULL parameters
2017-04-30 23:29:54 INFO Decrypted /var/folders/v5/6pdpvnbn7pg9h41pnbsr1klscmtspv/T/ssl_test572616158 successfully
--- FAIL: TestAppendKeyPairWithPassword (0.01s)
	ssl_test.go:169: Failed to append certificate and key to tls config: x509: RSA key missing NULL parameters
FAIL
FAIL	github.com/github/orchestrator/go/ssl	0.061s
[user@myhost ~/src/orchestrator/src/github.com/github/orchestrator]$

This is true for me as of commit

commit c61104ea3b9a853affe6c4a6d4f7d37f420ae27d
Merge: 5a9547b1 72a59a23
Author: Shlomi Noach <shlomi-noach@github.com>
Date:   Thu Apr 20 17:51:33 2017 +0300

Shlomi, does this build and work for you? If so there's some difference in our environment which is triggering this and I would like to fix mine so the build works cleanly and I can really check that go test ./go/... actually works. If it makes any difference this is being run on OSX, but also get an issue on Linux.

Note: the build checks via travis do seem to work, so there's some difference here between what you ask us to check if someone creates a PR and what actually gets checked by travis.

[shlomi-noach]

@sjmudd works for me. Which branches does this fail for you on? master?

[shlomi-noach]

I do believe you were the last to work on TLS. Perhaps some change in your local environment? I'd be happy to know what that change was so as either to eliminate it in the tests or enforce it in the tests. We should all get same test status.

[sjmudd]

No this does not work for me on your own master branch. This is not a build of a forked copy of orchestrator. If this builds for you then I guess I need to check with you offline to see if I can figure out what's different in our configuration. Some setup or otherwise of certificates perhaps or something else?