Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid promotion if replica not up-to-date with relay log (configurable?) #88

Closed
shlomi-noach opened this issue Feb 24, 2017 · 2 comments
Closed

Avoid promotion if replica not up-to-date with relay log (configurable?) #88

shlomi-noach opened this issue Feb 24, 2017 · 2 comments
Assignees
@shlomi-noach

Comments

@shlomi-noach
Copy link
Collaborator

Storyline: #83

(at least configurable?)

On master failover, do not promote a replica if it hasn't consumed its relay logs. This event can happen when all replicas are greatly lagging on time of master failure.
In such case a reset slave all on the promoted replica causes data loss.

Typically replicas are not lagging so much, and by the time the failure detection takes place, they will have consumed their relay logs.
@shlomi-noach shlomi-noach self-assigned this Feb 24, 2017
@shlomi-noach shlomi-noach mentioned this issue Mar 20, 2017
Merged
@shlomi-noach
Copy link
Collaborator Author

#104 has been merged.

@shlomi-noach
Copy link
Collaborator Author

released in https://github.com/github/orchestrator/releases/tag/v2.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shlomi-noach shlomi-noach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shlomi-noach