Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need easy way to search for senators #1198

Open
mackaymackay opened this issue Mar 21, 2019 · 10 comments
Open

Need easy way to search for senators #1198

mackaymackay opened this issue Mar 21, 2019 · 10 comments

Comments

@mackaymackay
Copy link
Contributor

There is currently no easy way to search for senators.

If you search by state/territory, both past and present senators appear, though only if a particular search term is used. Since we describe senators as "Senator for Queensland", you need to search by "Queensland" rather than "QLD". But since we use "Senator for NSW", you need to search by "NSW" rather than "New South Wales".

When a user searches by postcode, only their MP's record will show up.

A solution:
When a user searches by postcode, both their MP and their senators should be listed.

We should also make sure senators can be searched by their state/territory's long- and short-form names (i.e. "Northern Territory" + "NT"; "Tasmania" + "Tas")

@mackaymackay
Copy link
Contributor Author

This issue has been raised again via an email to the contact address (dated 27 Aug). In respect to how to solve it, the writer suggested that:

The search for the applicable senators for each state/territory, should be able to easily be done, using the first digit of the postcode used as the search parameter (assuming that the NT and ACT, each, have unique first digits of their postcodes).

@katska katska added this to To do in 2022 Federal Election Oct 11, 2021
@stale
Copy link

stale bot commented Oct 13, 2021

This issue has been automatically marked as stale because there has been no activity on it for about six months. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you!

@stale stale bot added the wontfix label Oct 13, 2021
@mlandauer
Copy link
Member

This is something we should address

@stale stale bot removed the wontfix label Oct 18, 2021
@mlandauer mlandauer removed this from To do in 2022 Federal Election Nov 29, 2021
@mlandauer mlandauer added this to the 2022 Federal Election milestone Dec 1, 2021
@bobsbarrels
Copy link
Contributor

In routes that "/people/:house/:mpc" => redirect("/people/%{house}")
https://github.com/openaustralia/publicwhip/blob/master/config/routes.rb#L32

If instead this was broken out in to own controller/view this allows a list of senators per state (for example).

Code is here: bobsbarrels@5baf204

Screenshot from 2021-12-15 10-11-30

This also would provide a place for "history" of electorates, though still a problem with how to manage redistribution.

But actually creating this view was only incidental to trying to insert a map (using leaflet, D3js and openstreetmaps). It'd be nice to discuss the map work further as there's also a version of this for electorates (based on data provided by AEC) which is pretty cool and alleviates a bunch of other issues.

map_senators_rails

@mlandauer mlandauer moved this from To do to To do (bugs) in 2022 Federal Election Feb 2, 2022
@mlandauer mlandauer moved this from To do (bugs) to To do (bugs) prioritised in 2022 Federal Election Feb 3, 2022
@mlandauer mlandauer moved this from To do (bugs) prioritised to To do (prioritised) - please do not reorder in 2022 Federal Election Feb 7, 2022
@MutazAshhab MutazAshhab self-assigned this Feb 7, 2022
@mlandauer mlandauer removed this from the 2022 Federal Election milestone Feb 13, 2022
@stale
Copy link

stale bot commented Aug 15, 2022

This issue has been automatically marked as stale because there has been no activity on it for about six months. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you!

@stale stale bot added the wontfix label Aug 15, 2022
@katska katska removed the wontfix label Aug 17, 2022
@katska
Copy link
Contributor

katska commented Aug 17, 2022

hmm sounds like "current" senators could be defined somewhere in that mix, either in the search terms, so only current senators are returned if that term is used, or that the search results distinguish separate current and past senators clearly.

@katska
Copy link
Contributor

katska commented Aug 17, 2022

Also seems like #1329 (awaiting conflicts to be resolved before merge) only solves a part of this issue

@stale
Copy link

stale bot commented Feb 13, 2023

This issue has been automatically marked as stale because there has been no activity on it for about six months. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you!

@stale stale bot added the wontfix label Feb 13, 2023
@stale stale bot closed this as completed Feb 20, 2023
2022 Federal Election automation moved this from To do (prioritised) - please do not reorder to Done Feb 20, 2023
@mackaymackay mackaymackay reopened this Feb 23, 2023
2022 Federal Election automation moved this from Done to In progress Feb 23, 2023
@stale stale bot removed the wontfix label Feb 23, 2023
@stale
Copy link

stale bot commented Aug 23, 2023

This issue has been automatically marked as stale because there has been no activity on it for about six months. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you!

@stale stale bot added the wontfix label Aug 23, 2023
Copy link

stale bot commented Feb 21, 2024

This issue has been automatically marked as stale because there has been no activity on it for about six months. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you!

@stale stale bot added the wontfix label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants