Skip to content
This repository has been archived by the owner on May 16, 2019. It is now read-only.

Cannot read property css of undefined in the first screen, Select Language #1865

Closed
jjeffryes opened this issue Jul 23, 2017 · 2 comments
Closed

Comments

@jjeffryes
Copy link
Contributor

Brief Description: Clicking next on the very first onboarding screen doesn't work because this.accWin is undefined.

Operating System (OS and version): macOS 10.12.5
OpenBazaar version (shown on About OpenBazaar page in menu): 1.1.11
Hardware: Macbook Pro 2016

Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce): Always

Steps to reproduce:

  1. Install app
  2. Launch, See "Select Your Language" with English preselected
  3. Click "Next >"

Observed Behavior:
Nothing happens. Opening developer tools shows this error every time "Next >" is pressed:
screen shot 2017-07-22 at 21 38 34

Expected Behavior:
I move to the next screen of onboarding

Originally reported here by @lekevicius
OpenBazaar/openbazaar-desktop#579

@jjeffryes
Copy link
Contributor Author

jjeffryes commented Jul 23, 2017

This appears to be caused by line 50 of currencyListVw.js, which is calling "https://api.bitcoinaverage.com/ticker/global/all". That call takes a long time to resolve, and failed when I tested it, which prevents the accordion from initializing.

If the user waits for the call to fail, they will be able to proceed, but the only currency option will be Bitcoin.

The url to retrieve a list of currency should be updated to one that works, or a conservative default list should be used.

In addition, a spinner or other indicator should be added so users know they are waiting on the response for the currency, and a message should be shown if it fails.

@jjeffryes
Copy link
Contributor Author

This has been fixed by updating the API.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant