Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Break down openbazaard.go into smaller files #26

Closed
duosearch opened this issue Jul 20, 2016 · 3 comments
Closed

Break down openbazaard.go into smaller files #26

duosearch opened this issue Jul 20, 2016 · 3 comments
Labels
feature Feature or enhancement to openbazaar-go

Comments

@duosearch
Copy link
Contributor

In the OB1.0 OpenBazaar-Server repo, the file openbazaard.py was very difficult to work with because it was long and linear (lots of "spaghetti"). openbazaard.go seems to be headed in a similar direction, with close to 500 lines of code.

Does it make sense to break down openbazaard.go into smaller files?

@cpacia
Copy link
Member

cpacia commented Jul 20, 2016

@tyler-smith you can give your opinion here. I'm not sure I see any logical place to break up the code as it's just initializing everything.

@tyler-smith
Copy link
Member

Yeah almost the bulk of the code is in the server initialization. You could break out logging and command handlers to their own files but I don't think that'd be things much better. You'd still have a giant Start.Execute() that's pretty unavoidable. I don't care too much one way or another if somebody submits a PR with a good refactoring.

@hoffmabc hoffmabc added the feature Feature or enhancement to openbazaar-go label Jul 20, 2016
@cpacia
Copy link
Member

cpacia commented Oct 8, 2016

Closing because I mostly agree with Tyler. If someone wants to submit a PR that puts some parts into a separate file I'd be open to it.

@cpacia cpacia closed this as completed Oct 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Feature or enhancement to openbazaar-go
Projects
None yet
Development

No branches or pull requests

4 participants