Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis more permanently #132

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ikmckenz
Copy link
Contributor

@ikmckenz ikmckenz commented Feb 13, 2020

This will be a work in progress until I finish stripping out everything Travis doesn't need, to prevent this error from effecting us in the future. Don't merge until it's done. This is fixes #131 .

Edit: Easy as predicted, this is ready to merge.

@ikmckenz ikmckenz changed the title Remove libatlas3gf-base from Travis apt get Fix Travis more permanently Feb 13, 2020
@codecov-io
Copy link

codecov-io commented Feb 13, 2020

Codecov Report

Merging #132 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   37.46%   37.34%   -0.13%     
==========================================
  Files           9        9              
  Lines        1588     1588              
==========================================
- Hits          595      593       -2     
- Misses        993      995       +2
Impacted Files Coverage Δ
openbci/utils/ssdp.py 26.66% <0%> (-4.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25232ac...0fd03cc. Read the comment docs.

@ikmckenz
Copy link
Contributor Author

Okay, build fixed and working. But now I will go through and chop out all the excess stuff that is in there, so this doesn't impact us again in the future.

@ikmckenz
Copy link
Contributor Author

Well that was easy, turns out we didn't need any of those apt installs. This should be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default distro in Travis changed, breaking build
2 participants