Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] GraphQL Datasources #9

Closed
deathemperor opened this issue Nov 15, 2022 · 9 comments
Closed

[Feature Request] GraphQL Datasources #9

deathemperor opened this issue Nov 15, 2022 · 9 comments
Labels
datasources enhancement New feature or request

Comments

@deathemperor
Copy link

No description provided.

@hanshuai
Copy link
Contributor

GraphQL integration is in our roadmap. Please stay tuned for updates : )

@neon-balcony neon-balcony added the enhancement New feature or request label Nov 15, 2022
@a-c-m
Copy link

a-c-m commented Nov 15, 2022

+1 to this.

Also Is your roadmap public?

@hanshuai
Copy link
Contributor

We'll be publishing our roadmap soon.

@voidberg
Copy link

Another +1 to this.

@lmx1117
Copy link
Collaborator

lmx1117 commented Dec 9, 2022

Hi everyone, GraphQL data source is available now, please check it out, and thanks again for your advice and patience. 😉

@ulbrich
Copy link

ulbrich commented Dec 13, 2022

Hi there, while the integration feels really good, the data transmitted to the server has a flaw: Variables are no JSON but as string… 🙂

See example here:

  "variables": "{\"email\":\"foo@bar.com\",\"password\":\"too-many-secrets\"}",
  "query": "query authenticateByEmail($email: String!, $password: String!) {\n  authenticateByEmail(arg1: {email: $email, password: $password}) {\n    jwtToken\n  }\n}"
}

This would be correct:

{
  "variables": { "email": "foo@bar.com", "password": "too-many-secrets" },
  "query": "query authenticateByEmail($email: String!, $password: String!) {\n  authenticateByEmail(arg1: {email: $email, password: $password}) {\n    jwtToken\n  }\n}"
}

@lvhuichao
Copy link
Contributor

lvhuichao commented Dec 14, 2022

Hi @ulbrich , thanks for reporting this issue. We will fix it in the next version, please stay tuned.

@neon-balcony
Copy link
Contributor

Hey @ulbrich , a hot fix image for this issue has been published, please update Openblocks and give us a try 😄

@ulbrich
Copy link

ulbrich commented Dec 15, 2022

Hi @neon-balcony, I can happily confirm that the fix works nicely communicating with Hasura using GraphQL queries. Thank you so much! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasources enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

8 participants