Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security/test_bmc_network_security.robot requires sudo for ICMP #2142

Open
generatz opened this issue Jan 5, 2022 · 2 comments
Open

security/test_bmc_network_security.robot requires sudo for ICMP #2142

generatz opened this issue Jan 5, 2022 · 2 comments
Assignees

Comments

@generatz
Copy link
Contributor

generatz commented Jan 5, 2022

security/test_bmc_network_security.robot uses nping with ICMP. ICMP creates a raw socket, which requires root privilege / sudo.

At a minimum, this should be mentioned in the Documentation on the second line of the file.
I'd also like to see a check in the appropriate test's Setup that verifies that the EUID is 0.
And perhaps the script should be split in two, putting the tests that require sudo into a separate script for safety and convenience.

@gkeishin
Copy link
Member

gkeishin commented Jan 7, 2022

Thanks @generatz for the feedback..

Documentation, we should definitely add, as for the script to handle, I ll let @prkatti1 take a call on it.

@prkatti1
Copy link
Contributor

Looked into it, will add the documentation for which TCs we need sudo privileges.
For 1 or 2 TCs we'll not have separate suite, will leave it to user to have proper infrastructure before running it.(New Documentation will help here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants