Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New OCC sensors - performance mode and memory power down #1368

Closed
geissonator opened this issue Mar 22, 2017 · 7 comments
Closed

New OCC sensors - performance mode and memory power down #1368

geissonator opened this issue Mar 22, 2017 · 7 comments
Assignees

Comments

@geissonator
Copy link
Contributor

New OCC sensors being defined.

  • Maximum Performance Mode vs Nominal Performance Mode
    -- Just a 0/1 type value, default is 0 (nominal), Maximum is 1
  • Memory Power Down settings
    -- Just a 0x00 type value, TBD on what the values mean
@vishwabmc
Copy link
Contributor

vishwabmc commented Sep 7, 2017

TASK LIST

  • Write yaml file for Performance Mode

[ ] Write yaml for Power down setting --> Not needed per discussion with Todd

  • Implement the above 2

or probably have just one org/open_power/OCC/Setting.inerface.yaml that defines these 2 ( need to talk )

  • Make changes in IPMI yaml file to target new D-Bus object on sensor calls

@vishwabmc
Copy link
Contributor

vishwabmc commented Sep 8, 2017

STATUS

  • 9/8:
    • Decided to write 2 YAML files and 2 implementations based on the discussion. Have not started writing yaml
  • 9/11:
    • Read the Thermal document and saw the below mentioned mode. Will talk to OCC folks on this
  • 9/12:
    • Wrote the Performance mode yaml and posted for review
    • Wrote the implementation for perf mode and posted for review
    • Need to talk to Todd to see if the mode applies to all or just the master

@vishwabmc
Copy link
Contributor

vishwabmc commented Sep 11, 2017

I looked at the Power Thermal document and it defines following Modes.

  • Nominal
  • Nominal dynamic performance
  • Maximum dynamic performance
  • Dynamic Power - Favor Performance ( not sure what this is )
  • Fixed max frequency

Will talk to OCC folks and see what is really needed from this doc.

@vishwabmc
Copy link
Contributor

Discussed with Todd on this and here is what it is :

  • Only Nominal and Maximum are needed since the rest are only for PowerVM
  • Boolean 0/1 for the Performance Mode
  • No need of the Memory Power Down sensor
Todd Rosedahl [3:06 AM] 
Hi.  So I checked around and since Witherspoon will default this to 0x00, there is no need to implement anything here actually.  So that saves you some work.

[3:07] 
We do not need to override it to other values.  And no need for an OpenBMC sensor for this at all```

@mdmillerii
Copy link
Contributor

Using a single boolean to control power / performance trade-offs seems like a tatical decision for witherspoon versus a design for many open power (or even other power9) systems.

@bradbishop @geissonator Agree?

@anoo1 anoo1 added bitesize and removed bitesize labels Sep 12, 2017
@vishwabmc
Copy link
Contributor

@geissonator please cancel this issue per the email I forwarded last week.

Todd indicated that we do not do any work on this for now.

@geissonator
Copy link
Contributor Author

Closing out per discussion with Todd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants