Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factory Reset #45

Closed
derick-montague opened this issue Nov 19, 2020 · 5 comments
Closed

Factory Reset #45

derick-montague opened this issue Nov 19, 2020 · 5 comments
Assignees
@ParishrutB @priyanka-pillai97
Labels
enhancement New feature or request
Projects
Design Reviews

Comments

@derick-montague
Copy link
Contributor

No description provided.

@derick-montague derick-montague created this issue from a note in Design Reviews (In progress) Nov 19, 2020
@priyanka-pillai97
Copy link

Use Case

As an admin, I want to factory reset to get a clean system, so that for example, I can re-purpose my system.


As a customer Support team member, I need to factory reset to fix a problem, so that the system can continue working as it was before.

As a user, I want to reset the Hypervisor settings to configure it to a non-HMC managed system. 


Design Review Workflow

  1. Each design iteration will have a comment section
  2. The section will include:
    • A title with the iteration number
    • Any description or specific feedback the designer is requesting
    • Screenshots of the workflow
  3. Based on community and user feedback, we create a comment for the new iteration and repeat these steps

@priyanka-pillai97
Copy link

priyanka-pillai97 commented Nov 25, 2020 •
edited
Loading

Factory Reset Iteration 1

Main screen - View Factory Reset options + associated affected settings for each.

FactoryReset-Main

The Affected Settings of each option can be opened by expanding the drop-down to know more about each Factory Reset.
FactoryReset-PowerON-Both expanded

After choosing Reset all settings (BMC and Hypervisor) option
FactoryReset-Main Copy 2 1
FactoryReset-Main Copy 2 2

Difference in modals when the server is powered OFF and the server is powered ON

When the server is Powered OFF
FactoryReset-Main Copy 2 1

When the server is Powered ON
Since powering off the system may not be required for all community members. 
The workflow would show the warning message in a modal that the server is still powered ON. The modal would ask them to confirm via a checkbox if they would like to continue with the reset even if the power is ON.
FactoryReset-Main Copy 2 3
FactoryReset-Main Copy 2 4

@priyanka-pillai97
Copy link

priyanka-pillai97 commented Nov 25, 2020 •
edited
Loading

Questions for community

  1. There are two options to reset - Reset All and Reset Hypervisor Settings. For the second option, what does the community prefer – Host / BIOS / Hypervisor / Firmware ? Which is more generic + accurate?
  2. Do you allow a factory reset even while the server is powered ON? Would you recommend against it knowing that it might cause a fatal error?

@derick-montague derick-montague added the enhancement New feature or request label Dec 9, 2020
@priyanka-pillai97
Copy link

priyanka-pillai97 commented Dec 18, 2020 •
edited
Loading

Factory Reset Iteration 2

Main screen - View Factory Reset options + associated affected settings for each.
Changes made: Moved to radio buttons to show the information upfront.
FactoryReset-Landing (1) (1) (4)

After choosing the Reset BMC and Host firmware option

FactoryReset-Landing (1) (1) (8)
FactoryReset-end (1) (1) (4)

Difference in modals when the server is powered OFF and the server is powered ON

When the server is Powered OFF
FactoryReset-Landing (1) (1) (6)

When the server is Powered ON
FactoryReset-Landing (1) (1) (9)

@derick-montague
Copy link
Contributor Author

This is not a requirement for Intel and we have not received feedback from any other community members. This have been implemented and we can address concerns in new issues.

@derick-montague derick-montague moved this from In progress to Done in Design Reviews Mar 31, 2021
rfrandse referenced this issue in ibm-openbmc/webui-vue Jul 28, 2022
@gtmills
Add Event Logs to Server Factory Reset (#45)
f696d88 
* Add Event Logs to Server Factory Reset

From discussion in slack
https://ibm-systems-power.slack.com/archives/C0Q6TQP5Z/p1641999140135900
A host factory reset clears the event logs.
Add event logs to the help text explaining what is cleared.

Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

* Change help text to reset server settings

Before the help text read "Resets firmware settings including:". This
doesn't make sense especially with the addition of the event logs to
this list.

Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
rfrandse referenced this issue in ibm-openbmc/webui-vue Jul 28, 2022
@gtmills @rfrandse
Add Event Logs to Server Factory Reset (#45)
dac9967 
* Add Event Logs to Server Factory Reset

From discussion in slack
https://ibm-systems-power.slack.com/archives/C0Q6TQP5Z/p1641999140135900
A host factory reset clears the event logs.
Add event logs to the help text explaining what is cleared.

Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

* Change help text to reset server settings

Before the help text read "Resets firmware settings including:". This
doesn't make sense especially with the addition of the event logs to
this list.

Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
rfrandse referenced this issue in ibm-openbmc/webui-vue Jul 28, 2022
@gtmills @dixsie
Add Event Logs to Server Factory Reset (#45)
f988eda 
* Add Event Logs to Server Factory Reset

From discussion in slack
https://ibm-systems-power.slack.com/archives/C0Q6TQP5Z/p1641999140135900
A host factory reset clears the event logs.
Add event logs to the help text explaining what is cleared.

Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

* Change help text to reset server settings

Before the help text read "Resets firmware settings including:". This
doesn't make sense especially with the addition of the event logs to
this list.

Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ParishrutB ParishrutB

@priyanka-pillai97 priyanka-pillai97

Labels
enhancement New feature or request
Projects
Design Reviews
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@derick-montague @ParishrutB @priyanka-pillai97