New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Action > Update Open Brewery DB API #12
Comments
May I ask what the action would be doing? To update the Rails API postgres db on merge to master? |
Yup! Though after our recent conversations, I'm getting less convinced this is the proper way. I like using Github's diff and version control features, but it's not incredibly user-friendly for those who just want to update data. Now I'm considering a reasonably authenticated and authorized data admin interface which will then collect and open a pull request on this repo. Definitely more complicated, but more user-friendly. Thoughts? |
Yeah I think that would be interesting. We would probably want to have Github authentication. I think that would just be easier since we're wanting to make a PR out of it. My initial thoughts would be that we could just add this to the gatsby page. I think it would be more work to create a brand new webpage, specifically designed for adding/editing when we already have the existing gatsby page (not to mention cost of hosting). Although, we wouldn't need to host it if we wanted to keep this solely as a locally run page. Thoughts on functionality
|
Awesome! Thanks for writing up your thoughts. Here are mine! 😄
Overall, this is feeling like a separate issue, perhaps even an epic that needs to be broken down. Also need to decide if this should live here (with the dataset) or with the website repo. 🤔 |
Yeah I saw your issue for re-making the website in Svelte. I've never used that but I'd like to give it a go. I have no eye for UI design though.
I bet we could pull some inspiration from Intellij (https://github.com/JetBrains/intellij-community/search?q=git)
I definitely agree this is something that is iterative. At least initially, I think it should be part of the main dataset repo. Then build it into the Svelte site. If it's part of the main dataset repo, it's right there and easy to spin up and add to. I'll open a new issue for this continuing conversation and close this one out. |
Closing this issue because as mentioned in the above conversation, it doesn't seem like this is the path forward. |
No description provided.
The text was updated successfully, but these errors were encountered: