Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contract spending - use 'entity_name' and 'entity_id' #24

Closed
akariv opened this issue Jun 21, 2017 · 3 comments
Closed

contract spending - use 'entity_name' and 'entity_id' #24

akariv opened this issue Jun 21, 2017 · 3 comments
Assignees

Comments

@akariv
Copy link
Member

akariv commented Jun 21, 2017

Prefer to use 'entity_name' and 'entity_id' Instead of 'supplier' and 'supplier_name'.
Only if the first two are empty, fall back to the 'supplier' ones.

@danielbraun
Copy link
Member

I'm on it

@shaylavi
Copy link
Contributor

is that the object that's returning from the search results? cause I'm using the "supplier" object in the new highlight component

@akariv
Copy link
Member Author

akariv commented Jun 27, 2017

Yes, we should be using the 'entity_name' whenever it's available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants