Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Read response source toggle in request block #52

Closed
beer15 opened this issue Mar 10, 2021 · 5 comments
Closed

[REQUEST] Read response source toggle in request block #52

beer15 opened this issue Mar 10, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@beer15
Copy link

beer15 commented Mar 10, 2021

Hi ruri, first of all thank you for the work you do,

Here are some functions that were really useful in OB1 that I don't see in OB2 and I think it's a good thing to put them in version 2, here is the list.

  • Read Resp. Source toggle, request block
  • search in the debugger
  • HTML View not always available, a bug ?
  • Put the proxy API function of ob1, so we don't need to enter it anymore, the link to update the proxies at each launch is done automatically, it's a really practical option that saves a lot of time
  • I also noticed one thing, sometimes in OB2 when I make a request I get the error "Operation cancelled
    BOT ENDED AFTER 15120 ms WITH STATUS: ERROR"

while in OB1 I have the same block no problem, a bug or the problem comes from me?

thanks

OB2 Version 0.1.1

@beer15 beer15 added the enhancement New feature or request label Mar 10, 2021
@openbullet
Copy link
Owner

openbullet commented Mar 10, 2021

Search in debugger = just use CTRL + F from browser
HTML View is available at the end of every source (with more than 1 line) after a request block, it's intended like this
For proxies see #25
Operation cancelled is because you set the Content-Length header manually, just remove it and it will work

@beer15
Copy link
Author

beer15 commented Mar 12, 2021

Search in debugger = just use CTRL + F from browser
HTML View is available at the end of every source (with more than 1 line) after a request block, it's intended like this
For proxies see #25
Operation cancelled is because you set the Content-Length header manually, just remove it and it will work

ok thanks i can put some suggestions here ? or i have to make another issue

@openbullet
Copy link
Owner

Please open 1 issue for each thing otherwise it's a mess. We will keep this open to impement the "read response source" checkbox, although I would still like to know the purpose of having that when you can just send a HEAD instead of a GET.

@openbullet openbullet changed the title [REQUEST] suggestions for ob2 [REQUEST] Read response source toggle in request block Mar 16, 2021
@openbullet
Copy link
Owner

Please let me know why this setting needs to be implemented. I assume it's for when a website sends a massive source, but it can be prevented in 2 ways.
If it's a GET request, just send a HEAD request instead so the server will only send headers and not the source.
Otherwise you can use this snippet, which only disables the log for that specific block (all the variables are set regardless, only the log is not printed)

data.Logger.Enabled = false;
// Your HTTP request block here
data.Logger.Enabled = true;

Please let me know if this setting is essential, and why the 2 alternatives I proposed won't work. Thank you ^_^

@fairy-root
Copy link

Since we can get off with a mere disabling the logger function, I guess there's no need for the implementation of Read Source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants