Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllColumnsConverter should pay attention to column_index #46

Open
pdowler opened this issue Nov 24, 2018 · 0 comments
Open

AllColumnsConverter should pay attention to column_index #46

pdowler opened this issue Nov 24, 2018 · 0 comments

Comments

@pdowler
Copy link
Member

pdowler commented Nov 24, 2018

When expanding "SELECT * ..." into an explicit column list, the converter should use the column_index in the tap_schema to put the columns into a sensible order.

It is feasible that TapSchemaDAO.setOrdered(true) in the QueryRunner could possibly do that right (TableDesc.columns is a List which should preserve order) but it might be safer for AllColumnsConverter to do the sorting itself... in a really large service adding order by to the tap_schema might also not be a great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant