Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add ua method #8

Closed
nigelhorne opened this issue Oct 10, 2019 · 5 comments
Closed

Please add ua method #8

nigelhorne opened this issue Oct 10, 2019 · 5 comments

Comments

@nigelhorne
Copy link

Classes in the Geo::Coder::* namespace support the 'ua' method to get/set the useragent. See, for example, https://github.com/gitpan/Geo-Coder-Bing/blob/master/lib/Geo/Coder/Bing.pm

@freyfogle
Copy link
Member

Hi Nigel,

help me understand this please.
What is the use case of setting a different user agent then Geo::Coder::OpenCage $version which is already set? Why do I want users to set a different agent?

@nigelhorne
Copy link
Author

For example, in my script https://github.com/nigelhorne/ged2site, I use it to set the agent to be https://github.com/nigelhorne/LWP-UserAgent-Throttled to only send one request to OCD per second.

@freyfogle
Copy link
Member

ahh ok, I see, you want to pass in a user agent object not a user agent string. Sorry, wasn't clear to me. ok, got it. Let me see what we can do. Just due to a few other things going on, it probably won't be until early next week though.

@nigelhorne
Copy link
Author

Yes, that's correct. No rush.

@freyfogle
Copy link
Member

ok, I just went ahead and did it.
v0.24 is now on CPAN
https://metacpan.org/release/EDF/Geo-Coder-OpenCage-0.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants