Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of newly created user does not appear in selection list #1139

Closed
gregorydlogan opened this issue Oct 9, 2019 · 6 comments · Fixed by #1735
Closed

Name of newly created user does not appear in selection list #1139

gregorydlogan opened this issue Oct 9, 2019 · 6 comments · Fixed by #1735
Assignees
Labels
bug good first issue Issues which are easy to resolve, perfect for beginners hacktoberfest Good issue to work on as part of the Hacktoberfest

Comments

@gregorydlogan
Copy link
Member

Via https://opencast.jira.com/browse/MH-11526

Steps to reproduce (Users Page):

  1. Create a new user.
  2. After creation Press on the Filter icon in the filter bar.
  3. Select Name in the drop down.
  4. new user does not show up in the second filter selection drop down.

Actual Results:
The name of the new user does not show up in the second filter selection drop down.

Expected Results:
The name of the new user should show up in the filter drop down.

Workaround (if any):
Remove the filter by name - search is sufficient to find a user by name.

@gregorydlogan gregorydlogan added bug good first issue Issues which are easy to resolve, perfect for beginners hacktoberfest Good issue to work on as part of the Hacktoberfest labels Oct 9, 2019
@sharath2106
Copy link

@gregorydlogan I would like to work on this. Please assign this to me.

@sharath2106
Copy link

sharath2106 commented Oct 12, 2019

@gregorydlogan I just got sometime to work on this issue. And I've some questions for you -
On which module should I start working on? And also, how to run this in my local? I shall also add these instructions in the ReadME during my commit.

Screenshot 2019-10-12 at 11 48 22 AM

@sharath2106
Copy link

@gregorydlogan Any updates? I would need to set the app in my local environment.

@gregorydlogan
Copy link
Member Author

Hi @sharath2106, the issue in question lives in the admin-ui bundle, specifically in the src/main/webapp directory. You probably want to start here in terms of UI development. Building the backend is as easy as mvn clean install -P dev from the clone's directory. See here for better instructions.

@staubesv
Copy link
Contributor

@sharath2106 Happy to see that you are willing to help fixing this!

The symptom indicates that the Admin UI does not reload the filters after a new user has been created.

You can easily verify this by using the inspection feature of your web browsers feature that lists the HTTP requests. The request of question is GET /admin-ng/resources/{resource}/filters.json which loads all filters (including values) for the given page {resource}, e.g. GET /admin-ng/resources/users/filters.json on the page Organization->Users.
This happens whenever you change the page, but it seems not when you create a new user on the page Organization->Users.

The front-end code that runs when you add a new users is https://github.com/opencast/opencast/blob/develop/modules/admin-ui/src/main/webapp/scripts/modules/users/controllers/userController.js#L125.

Hope this helps and good luck!

@lkiesow
Copy link
Member

lkiesow commented Oct 4, 2020

Fixed by #1735

@lkiesow lkiesow closed this as completed Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Issues which are easy to resolve, perfect for beginners hacktoberfest Good issue to work on as part of the Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants