Process-smil WOH tag-with-profile configuration does not work depending on the encoding profile suffix configured #5689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5687
The issue was that if an encoding profile had a suffix starting with a '-' e.g. -presentation-3q-300k-25fps.mp4, workspace.toSafeName would change the first character to '_' e.g. _presentation-3q-300k-25fps.mp4, and the track would never be tagged with the profile name. This fix just adds a dummy character as the first one before toSafeName is called so that the 'suffix' is treated as a suffix, independently of the regex used.
Your pull request should…