Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process-smil WOH tag-with-profile configuration does not work depending on the encoding profile suffix configured #5689

Conversation

rute-santos
Copy link
Contributor

This PR fixes #5687

The issue was that if an encoding profile had a suffix starting with a '-' e.g. -presentation-3q-300k-25fps.mp4, workspace.toSafeName would change the first character to '_' e.g. _presentation-3q-300k-25fps.mp4, and the track would never be tagged with the profile name. This fix just adds a dummy character as the first one before toSafeName is called so that the 'suffix' is treated as a suffix, independently of the regex used.

Your pull request should…

@rute-santos rute-santos changed the base branch from develop to r/15.x March 22, 2024 15:08
@gregorydlogan gregorydlogan self-assigned this Apr 12, 2024
@gregorydlogan gregorydlogan merged commit bd34271 into opencast:r/15.x Apr 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants