Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremally poor utilisation of space in browser map #168

Closed
baryluk opened this issue Oct 15, 2020 · 3 comments
Closed

Extremally poor utilisation of space in browser map #168

baryluk opened this issue Oct 15, 2020 · 3 comments

Comments

@baryluk
Copy link

baryluk commented Oct 15, 2020

Screenshot at 2020-10-15 20-09-47

Only 34% of available space is utilized.

I am pretty sure this can be upped to 90%, maybe 95%.

Inspecting HTML, it looks there is a hardcoded size of the iframe: style="width:100%;height:600px"

@webprofusion-chrisc
Copy link
Member

Thanks, yes, of course on my 1080 high display it looks great :)

I think to do that properly we'd need to get rid of the other front page content so we can fill the remaining height?

https://map.openchargemap.io is the real map site, as you can probably tell the iframed version is kind of a second class citizen on that front page.

@webprofusion-chrisc
Copy link
Member

Ok, I've removed the bottom content that nobody reads anyway and removed some of top padding and the old Add link (people should generally use the map/app to add locations now). See what you think.

@baryluk
Copy link
Author

baryluk commented Oct 18, 2020

Yes, beautiful. Thank you!

@baryluk baryluk closed this as completed Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants