Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject env variables for corporate proxy #113

Closed
nckbgov opened this issue Apr 11, 2022 · 6 comments · Fixed by #114
Closed

inject env variables for corporate proxy #113

nckbgov opened this issue Apr 11, 2022 · 6 comments · Fixed by #114

Comments

@nckbgov
Copy link

nckbgov commented Apr 11, 2022

If apiclarity needs to run on a cluster behind corporate proxy, wasm post install job fails to complete.

injection of env variables (HTTPS_PROXY, https_proxy, HTTP_PROXY, http_proxy, no_proxy, NO_PROXY) and update git config (git config --global http.proxy, git config --global https.proxy) fixes the issue

@FrimIdan
Copy link
Member

Hi @nckbgov thanks for the report.
Can you please share what changes needed to be done so we will update the helm templates and values.

@nckbgov
Copy link
Author

nckbgov commented Apr 11, 2022

Hi @FrimIdan,

https://github.com/apiclarity/apiclarity/blob/b1f6d4f657cbb9f2ce70355730b873e77c1c94c5/charts/apiclarity/templates/post-install-job-wasm.yaml#L83 needs to have git http(s) config included:

 git config --global http.proxy http://proxy.acme.com:80 && git config --global https.proxy http://proxy.acme.com:80

In the current version i ran on an ephemeral pod the following command:

/bin/bash -c cd /tmp && git config --global http.proxy http://proxy.acme.com:80 && git config --global https.proxy http://proxy.acme.com:80 && git clone -b v0.9.0 https://github.com/apiclarity/apiclarity.git --recurse-submodules && cd apiclarity/wasm-filters && WASM_FILTER_TRACE_BACKEND_ADDRESS=apiclarity-apiclarity.apiclarity.svc.cluster.local ./deploy.sh open5gs

@FrimIdan
Copy link
Member

@nckbgov , ok we can add this line if proxy is used. What about the env variables (HTTPS_PROXY, https_proxy, HTTP_PROXY, http_proxy, no_proxy, NO_PROXY)?

@nckbgov
Copy link
Author

nckbgov commented Apr 11, 2022

Good point. In general we inject the 6 variables to all pods.
But for this particular issue only two can be used to update git http.proxy and git https.proxy

@FrimIdan
Copy link
Member

@nckbgov can you take a look at #114 and see if that solves your issue?

@nckbgov
Copy link
Author

nckbgov commented Apr 11, 2022

Thanks @FrimIdan, #114 will solve the issue!

@nckbgov nckbgov closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants