Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing strip so description is right #160

Merged
merged 3 commits into from May 12, 2019
Merged

Add missing strip so description is right #160

merged 3 commits into from May 12, 2019

Conversation

znicholls
Copy link
Collaborator

Strips lines before comparison so project description is as intended

  • Implementation finished
  • Tests added (N/A)
  • Documentation added
  • Example added (in the documentation, to an existing notebook, or in a new notebook) (N/A)
  • Description in CHANGELOG.rst added (single line such as: (`#XX <https://github.com/openclimatedata/openscm/pull/XX>`_) Added feature which does something) (N/A)

@znicholls znicholls requested a review from swillner May 6, 2019 22:56
swillner
swillner approved these changes May 12, 2019
View reviewed changes
Copy link
Member

@swillner swillner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Why exactly was that necessary?

setup.py Outdated Show resolved Hide resolved
@znicholls @swillner
Update setup.py
f5654c6 
Co-Authored-By: Sven Willner <sven.willner@gmail.com>
@znicholls
Copy link
Collaborator Author

Why exactly was that necessary?

Trailing whitespace meant if line.strip() == ".. sec-begin-long-description": wasn't being hit.

@znicholls znicholls merged commit 151c43f into master May 12, 2019
@swillner swillner deleted the update-setup-py branch May 14, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swillner swillner swillner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@znicholls @swillner