Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use guidelines #166

Merged
merged 7 commits into from Jun 5, 2019
Merged

Add use guidelines #166

merged 7 commits into from Jun 5, 2019

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented May 24, 2019

Adds usage guidelines to OpenSCM

  • Implementation finished (N/A)
  • Tests added (N/A)
  • Documentation added (N/A)
  • Example added (in the documentation, to an existing notebook, or in a new notebook) (N/A)
  • Description in CHANGELOG.rst added (single line such as: (`#XX <https://github.com/openclimatedata/openscm/pull/XX>`_) Added feature which does something)

@rgieseke
Copy link
Member

Good idea to have some "expectation setting" in the Readme/Docs!

My 2-cent:

AGPL is not a "permissive" license in the usual usage in the OS community but a "copyleft" license i think (and MIT/BSD are permissive).

I strongly dislike co-authorships suggestions in other projects so would refrain here, too (though i haven't been much involved recently i probably should count much on this issue) - i'd think it's fine to notice that you're open to collaboration, but the license allows anyone to use it according to the license.

In OpenSCM's case it's also the case that it builds on other people's work heavily, so it's even more difficult whom to include. For PRIMAP-hist we went with

 When using this dataset, or one of its updates, please cite the DOI of the precise version of the dataset used and also the data description article to which this dataset is supplement. Please consider also citing relevant original sources when using the PRIMAP-hist dataset. References to the original sources can be found in the mansucript and on the dataset download page. 

So something like this might be appropriate for the SCMs shipping with OpenSCM in the future. I dislike lots of things about IIASA's SSP databases but i think them providing clear citation instructions and downloadable citation data is pretty great!

@swillner
Copy link
Member

I'm also not too much a fan of such notices. Maybe a short notice suffices that "we are open about collaboration"? I suppose, a nice CITATION file (with a specific formatted citation to copy-and-paste) would be of more value.

@znicholls
Copy link
Collaborator Author

Ok. So how about we go for:

  • notice in similar vein to PRIMAP-HIST (i.e. please consider citations of us and original source, open to collaboration)
  • CITATIONS file, in which we have citations for each model plus OpenSCM

?

Copy link
Member

@swillner swillner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be awesome ;)

@swillner
Copy link
Member

swillner commented Jun 3, 2019

Sorry, I missed your understanding of the CITATION file :/ It's supposed to include the way we would like OpenSCM to be cited (hence the singular).
Nevertheless, we should add a cite method to the adapter including those model citation.

@swillner
Copy link
Member

swillner commented Jun 3, 2019

... I like the new encouraging colaboration paragraph! Can you sort the maintainers alphabetically again, please?

@znicholls
Copy link
Collaborator Author

Nevertheless, we should add a cite method to the adapter including those model citation.

Should we also provide a file which has all the citations in one (pulling citations from all over the place is one of the things I hate most when writing papers)?

@znicholls
Copy link
Collaborator Author

Can you sort the maintainers alphabetically again, please?

Done

@swillner
Copy link
Member

swillner commented Jun 3, 2019

Nevertheless, we should add a cite method to the adapter including those model citation.

Should we also provide a file which has all the citations in one (pulling citations from all over the place is one of the things I hate most when writing papers)?

Maybe a function that collects all cite values from all available adapters?

@znicholls
Copy link
Collaborator Author

Maybe a function that collects all cite values from all available adapters?

Just feels unnecessarily complex, why not just have a file?

@rgieseke
Copy link
Member

rgieseke commented Jun 4, 2019

I think R has some standards to get a citation but i'm not aware of any default ways in Python. I think having a file (or just in the Readme) should be easier.

@swillner
Copy link
Member

swillner commented Jun 4, 2019

Ok, then maybe rename CITATIONS to CITATION and add a way to cite OpenSCM on top with an explanatory text and then give the other citations?

@znicholls
Copy link
Collaborator Author

Ok, then maybe rename CITATIONS to CITATION and add a way to cite OpenSCM on top with an explanatory text and then give the other citations?

Like so? Given we don't have a citation yet this is the best we can do right?

Copy link
Member

@swillner swillner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just two minor suggestions

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
Co-Authored-By: Sven Willner <sven.willner@gmail.com>
@swillner swillner merged commit fca4692 into master Jun 5, 2019
@swillner swillner deleted the usage-guidelines branch June 5, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants