Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low-level: Parameter handling #40

Merged
merged 27 commits into from
Dec 23, 2018
Merged

Low-level: Parameter handling #40

merged 27 commits into from
Dec 23, 2018

Conversation

swillner
Copy link
Member

@swillner swillner commented Nov 4, 2018 •
edited

  • Implementation finished
  • Tests added
  • Documentation added
  • Description in CHANGELOG.rst added

@swillner swillner self-assigned this Nov 4, 2018
@swillner swillner mentioned this pull request Nov 4, 2018
Closed
@rgieseke rgieseke changed the title Low-level: Parameter handling WIP: Low-level: Parameter handling Nov 5, 2018
@openscm openscm deleted a comment from codecov bot Nov 5, 2018
znicholls
znicholls requested changes Nov 5, 2018
View reviewed changes
Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swillner awesome start! Let me know if you want any more specific comments now

openscm/core.py Outdated Show resolved Hide resolved
openscm/core.py Outdated Show resolved Hide resolved
openscm/core.py Outdated Show resolved Hide resolved
openscm/core.py Outdated Show resolved Hide resolved
openscm/core.py Outdated Show resolved Hide resolved
openscm/core.py Outdated Show resolved Hide resolved
openscm/core.py Outdated Show resolved Hide resolved
openscm/core.py Outdated Show resolved Hide resolved
tests/unit/test_core.py Outdated Show resolved Hide resolved
tests/unit/test_core.py Outdated Show resolved Hide resolved
znicholls and others added 3 commits November 5, 2018 16:46
@znicholls @swillner
Update openscm/core.py
24da54d 
Co-Authored-By: swillner <sven.willner@gmail.com>
@znicholls @swillner
Update openscm/core.py
c937a5e 
Co-Authored-By: swillner <sven.willner@gmail.com>
@znicholls @swillner
Update openscm/core.py
27d8d86 
Co-Authored-By: swillner <sven.willner@gmail.com>
@openscm openscm deleted a comment from codecov bot Nov 5, 2018
@openscm openscm deleted a comment from codecov bot Nov 5, 2018
@openscm openscm deleted a comment from codecov bot Nov 6, 2018
@swillner
Copy link
Member Author

swillner commented Nov 6, 2018

@znicholls thanks for the feedback! further one is only needed after I have continued the work here...

@openscm openscm deleted a comment from codecov bot Nov 8, 2018
@openscm openscm deleted a comment from codecov-io Nov 8, 2018
@swillner swillner added the wip Work in progress (for PRs) label Nov 13, 2018
@swillner swillner changed the title WIP: Low-level: Parameter handling Low-level: Parameter handling Nov 13, 2018
@znicholls
Copy link
Collaborator

@swillner how far away are we on this? Would be brilliant to get into so I can have a crack and putting the full pipeline together with the PH99 adapter

@swillner
Copy link
Member Author

@znicholls I think I can finish it next week (this week on vacation). ok?

@znicholls
Copy link
Collaborator

Looking good @swillner, if you re-run the notebooks locally you'll pass CI

znicholls
znicholls reviewed Dec 22, 2018
View reviewed changes
docs/conf.py Show resolved Hide resolved
openscm/errors.py Outdated Show resolved Hide resolved
openscm/parameters.py Show resolved Hide resolved
@swillner
Copy link
Member Author

Great! I still need to include aggregated parameter views (#69), but I think we can merge this for now...

@znicholls
Copy link
Collaborator

@rgieseke for you to hit the button

@swillner swillner removed the wip Work in progress (for PRs) label Dec 23, 2018
@swillner swillner merged commit 48730dc into master Dec 23, 2018
@swillner swillner deleted the parameters branch December 23, 2018 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgieseke rgieseke rgieseke approved these changes

@znicholls znicholls znicholls approved these changes

Assignees

@swillner swillner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@swillner @znicholls @rgieseke