Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebooks installation extra #92

Merged
merged 4 commits into from Feb 5, 2019
Merged

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Feb 4, 2019

Also has a few other tweaks:

  • make black
  • make test now gives a brief coverage report in the terminal
  • updates the PR request template with our base url string

Pull request

Please confirm that this pull request has done the following:

  • Tests added (N/A)
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http://link-to-pr.com>`_) Added feature which does something
- (`#XX <http://link-to-pr.com>`_) Fixed bug identified in (`#XX <http://link-to-issue.com>`_)

Closes #90

@znicholls znicholls added the wip Work in progress (for PRs) label Feb 4, 2019
@znicholls znicholls removed the wip Work in progress (for PRs) label Feb 4, 2019
@znicholls znicholls requested review from swillner and rgieseke and removed request for swillner February 4, 2019 22:56
@znicholls
Copy link
Collaborator Author

@swillner @rgieseke I have no idea what is going on with Travis but the failure is for a PR which doesn't exist (93, see https://travis-ci.org/openclimatedata/openscm/builds/488755735). This PR, 92, seems to be fine but isn't appearing for some reason... https://travis-ci.org/openclimatedata/openscm/builds/488755170

@rgieseke rgieseke merged commit 2a91dba into master Feb 5, 2019
@rgieseke rgieseke deleted the 90-notebook-dependencies branch February 5, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants