Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orientation and tilt #6

Closed
Tracked by #1
peterdudfield opened this issue Nov 28, 2023 · 3 comments
Closed
Tracked by #1

Add orientation and tilt #6

peterdudfield opened this issue Nov 28, 2023 · 3 comments

Comments

@peterdudfield
Copy link
Contributor

peterdudfield commented Nov 28, 2023

Add orientation and tilt in here

Need to test out if the model changes its results depending on these values. We might need to change something in psp

@peterdudfield peterdudfield mentioned this issue Nov 28, 2023
21 tasks
@EdFage EdFage mentioned this issue Dec 7, 2023
@peterdudfield
Copy link
Contributor Author

@EdFage thanks for showing interest in this. This would be great to do, dont worry about changing psp, just

  1. add tilt and oreientation to the site pydnatic model, perhaps add a default of tilt=35 and orientation=180,
  2. add them to https://github.com/openclimatefix/Open-Source-Quartz-Solar-Forecast/blob/main/quartz_solar_forecast/data.py#L139

@EdFage
Copy link
Contributor

EdFage commented Dec 7, 2023

Sounds good, I'lll get on it!

@EdFage EdFage mentioned this issue Dec 7, 2023
5 tasks
@peterdudfield
Copy link
Contributor Author

Ill close this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants