Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move SQLAlchemy functions from ocf dashboard to here #86

Closed
rachel-labri-tipton opened this issue Oct 16, 2023 · 0 comments · Fixed by #87
Closed

move SQLAlchemy functions from ocf dashboard to here #86

rachel-labri-tipton opened this issue Oct 16, 2023 · 0 comments · Fixed by #87
Assignees

Comments

@rachel-labri-tipton
Copy link
Contributor

Detailed Description

There are several SQLAlchemy functions in the OCF Dashboard that it would make more sense to have in the pv-site-datamodel repo.

These functions can be found here in the get_data.py file in the OCF Dashboard code.

Context

These functions were not originally in the datamodel so were written for the dashboard functionality, but they interact directly with the database, and it would make sense for them to be accessible via the datamodel.

Possible Implementation

  • Add the functions and tests to the pv-site-datamodel.
  • Change the imports in the OCF Dashboard code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant