Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard button on the main menu #45

Open
007vedant opened this issue Oct 7, 2021 · 8 comments
Open

Leaderboard button on the main menu #45

007vedant opened this issue Oct 7, 2021 · 8 comments
Assignees
Labels

Comments

@007vedant
Copy link
Contributor

The code presently contains the logic to save top 3 high scores in the backend.
This issue aims at implementing a leaderboard button in the main menu to see top 3 highscores.

Hacktoberfest 2021 contributions are welcome 🚀 🎉

@bjuspi
Copy link
Contributor

bjuspi commented Oct 8, 2021

Hi, can you assign this to me ?

@007vedant
Copy link
Contributor Author

Hi @bjuspi Glad to assign this issue to you 🚀

@bjuspi
Copy link
Contributor

bjuspi commented Oct 8, 2021

Hi @bjuspi Glad to assign this issue to you 🚀

Thanks! I have a couple of questions regarding this issue:

  1. How can I get the asset for the main menu button ?
  2. What should the branch name for this issue should be following the contribution guideline naming convention, I'm quite confused ?

@007vedant
Copy link
Contributor Author

@bjuspi

  1. Assets for the main menu High Scores button will be added soon via Add assets for High Score button in main menu #48
  2. As per the contribution guidelines the name of the branch can be feat/Leaderboard button on the main menu

@bjuspi
Copy link
Contributor

bjuspi commented Oct 9, 2021

@007vedant

Thanks for the reply!

For now I can work using a dummy assets as the placeholder button

@007vedant
Copy link
Contributor Author

007vedant commented Oct 9, 2021

Hi @bjuspi, the assets for main menu High Scores have been added via PR #50.
Please consider pulling from upstream and using the assets 🔑 🚀

Assets can be found in /assets/menu with names

  1. high-scores-active.png
  2. high-scores-inactive.png

@bjuspi
Copy link
Contributor

bjuspi commented Oct 10, 2021

Hi @007vedant, thanks for the update

I've updated my branch, and the asset looks great!

@007vedant
Copy link
Contributor Author

@bjuspi any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants