-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSX build error: "/etc/os-release" does not exist #172
Comments
Could you create a PR for it as I don't know if we have an OSX maintainer? Thanks! |
I will do it over the weekend, and try to build atomspace properly as well. I found many issues with install_location in both code bases. No promises for long-term maintanance, but I am confident I can make it work short-term. |
Here's a quick hack:
does it work? |
That problem is solved by the following:
I'm now moving on to RPATH issues. I have atomspace built and passing most tests, except 27 tests using |
But |
added CMAKE_SYSTEM_VERSION |
I've set CMAKE_BUILD_WITH_INSTALL_RPATH to TRUE. I could put that in |
For me, |
fair enough. I'll hide it in an IF. |
I suspect that setting We've had repeated arguments about the unit tests, there is a strong contingent that wants to be able to run them without installing first. Which kind-of makes sense - you don't want to install something that's broken. I see this:
and so I am guessing that for OSX, the path |
Actually, with the base configuration as is, I have the bare name of the library (which fails.) I tried using INSTALL_NAME, and cmake kept trying to use the build path. RPath works fine on Mac (contra the cmake page quoted.) |
I had to move the calculation in the macro, because CMAKE_SYSTEM_NAME is not yet defined at the point where you calculated OS_VERSION. |
The CI tests are failing: |
Thank you, I just made it conditional to APPLE. |
Hang on, the tests are running now, and cogutil passed, lets see if atomspace passes. |
PS: this works with gcc-9 in homebrew, not with clang. |
I'll take patches for that, or an error message that prints "clang won't work". |
cmake/Summary.cmake:8
reads/etc/os-release
which does not exist on OSX, making the cmake fail. Simply commenting out the lines introduced in 264a199 allows the build to succeed.With apologies for the noise in #98, I did not read the error messages properly.
The text was updated successfully, but these errors were encountered: