Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'null' background image #315

Closed
znarf opened this issue Apr 16, 2018 · 1 comment
Closed

'null' background image #315

znarf opened this issue Apr 16, 2018 · 1 comment
Assignees

Comments

@znarf
Copy link
Member

znarf commented Apr 16, 2018

When browsing https://opencollective.com/yeoman

A null background image is loaded resulting in a bogus request to https://opencollective.com/null. That is in the end a performance issue because a full web page is loaded in place of a static image.

<div class="jsx-3812884289 jsx-3812884289 Member undefined large USER viewMode-USER">
  <div class="jsx-3812884289 jsx-3812884289">
    <a title="Frank Paczynski" href="/frankpaczynski">
      <div style="width:45px;height:45px;background-image:url(/static/images/avatar-01.svg)" class="jsx-179226476 jsx-179226476 Avatar undefined">
        <div style="background-image:url(null);width:45px;height:45px" class="jsx-179226476 jsx-179226476 image"></div>
      </div>
      <div class="jsx-3812884289 jsx-3812884289 bubble">
        <div class="jsx-3812884289 jsx-3812884289 name">Frank Paczynski</div>
        <div style="color:#797D7F" class="jsx-3812884289 jsx-3812884289 description"></div>
        <div style="color:#797D7F" class="jsx-3812884289 jsx-3812884289 meta since">Backer since October 2017</div>
        <div style="color:#797D7F" class="jsx-3812884289 jsx-3812884289 meta totalDonations">Total amount contributed: $3</div>
      </div>
    </a>
  </div>
</div>

In this snippet, there is also:

  • some `undefined' classes that could be removed.
  • a duplicate jsx class that could also be investigated.
@znarf znarf self-assigned this Apr 19, 2018
@znarf
Copy link
Member Author

znarf commented Apr 19, 2018

The duplicate class issue is mentioned here: vercel/styled-jsx#407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant