Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Base64 encoding SVGs #524

Closed
XhmikosR opened this issue Jun 17, 2018 · 4 comments
Closed

Stop Base64 encoding SVGs #524

XhmikosR opened this issue Jun 17, 2018 · 4 comments

Comments

@XhmikosR
Copy link

It results in much bigger files.

@znarf
Copy link
Member

znarf commented Jun 18, 2018

@XhmikosR Thank you for the report!

Can you provide an example? And give a short guidance on how to assess there is base64 encoding in the example?

@XhmikosR
Copy link
Author

@znarf I just noticed these issues in the OC PR created for BootstrapCDN. And looking at this repo's code, you can clearly see there's base64 used in some cases.

https://github.com/opencollective/frontend/search?q=base64&unscoped_q=base64

I'm not familiar with the codebase, hence why I don't submit a PR and just made an issue :)

@znarf
Copy link
Member

znarf commented Jun 18, 2018

Can you provide the URL of the BootstrapCDN SVG containing base64? Just to be sure we're looking at the same thing.

I think in some cases, base64 is used to embed avatars in the SVGs. That sounds ok, and I can't think of a better alternative.

@XhmikosR
Copy link
Author

I would swear I saw whole SVG files being base64 encoded but now I can't find it. I'm gonna close this for now and if I find any I will comment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants