Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StyledSelect accessibility #2056

Closed
Betree opened this issue May 21, 2019 · 4 comments
Closed

StyledSelect accessibility #2056

Betree opened this issue May 21, 2019 · 4 comments
Labels
complexity → medium frontend technical-debt Deprecated code to migrate and other necessary refactors wontfix

Comments

@Betree
Copy link
Member

Betree commented May 21, 2019

Reported here: https://twitter.com/WMassag/status/1130396510221492224

The StyledSelect component lacks accessibility. When typing the first letter(s) of the text it should behaves just like the native browser select and focus the most appropriate entry.

This is happening for the country select, but we should fix it at the component level to ensure all our existing and future selects will be covered.
@Betree Betree added complexity → medium frontend technical-debt Deprecated code to migrate and other necessary refactors labels May 21, 2019
@Betree Betree mentioned this issue Jun 19, 2019
Merged
@ghost
Copy link

ghost commented Jul 29, 2019

@Betree can I get more information about this issue.
PS: the twitter link is broken.

@Betree Betree added the wontfix label Jul 29, 2019
@Betree
Copy link
Member Author

Betree commented Jul 29, 2019

@NotJohs This issue should be fixed by our transition to react-select (see #2135). I'll soon open bounties to migrate the existing selects, stay tuned 😉

@ghost
Copy link

ghost commented Jul 29, 2019

@Betree alright

@Betree
Copy link
Member Author

Betree commented Aug 1, 2019

Closing this issue in favor of migrating to the new StyledSelect (that relies on react-select)

See #2292 #2293 #2294

@Betree Betree closed this as completed Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity → medium frontend technical-debt Deprecated code to migrate and other necessary refactors wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Betree and others