Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Collective name to credit card statements #2975

Open
Betree opened this issue Mar 10, 2020 · 8 comments
Open

Add Collective name to credit card statements #2975

Betree opened this issue Mar 10, 2020 · 8 comments
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) bounty candidate Potential bounty, to be reviewed. Having this tag on an issue does not qualify it for a bounty. complexity → simple feature stale

Comments

@Betree
Copy link
Member

Betree commented Mar 10, 2020

User story

As a financial contributor, I can see the collective name I'm contributing to on my credit card statement.

Today only the host name is displayed, but most users contribute to only one collective and probably don't know what the Open Source Collective is.

Today
image

Expected
image

Best solution for this problem

This can be achieved thanks to the statement_descriptor parameter. Note that the following rules apply:

  • Contains between 5 and 22 characters, inclusive.
  • Contains at least one letter.
  • Does not contain any of the special characters < > \ ' " *.
  • Reflects your doing business as (DBA) name.

So my suggestion would be:

statement_descriptor: truncate(`${host.name}: ${collective.name}`, {length: 22})

We also need to write a test to make sure that no matter what the host & collective names are (special characters, very short length...etc) this always meet the rules mentioned above (we may have to add some tweaks to achieve that).

Context

Requested in https://opencollective.freshdesk.com/a/tickets/4969
Should be re-thinked when implementing #1916

@Betree Betree added feature complexity → simple api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) labels Mar 10, 2020
@flaki
Copy link

flaki commented Mar 24, 2020

For an added data point, our host name is already 22 characters in itself so the proposed solution wouldn't leave us with anything better than the current situation.

I would probably prefer to allow hosts to change this on a per-collective basis for the collectives they host. Our own Stripe account already is set to use "BAYTECH", so I would imagine for Rust Tallinn we would want to set this to "RUST TALLINN / BAYTECH" while for Bay Area Tech Club we would probably just leave this as "BAYTECH" (or spell out BAY AREA TECH CLUB).

@Betree
Copy link
Member Author

Betree commented Mar 26, 2020

@flaki thanks for the additional info. Then what I'd suggest is for us to add a setting inside collective.settings.shortName for hosts and collectives to customize the value that will be used on their statements.

@stale
Copy link

stale bot commented Jun 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. We haven't had the time to address it yet, but we want to keep it open. This message is just a reminder for us to help triage issues.

@stale stale bot added the stale label Jun 26, 2020
@Deep1Shikha
Copy link

@Betree could you assign it to me?

@Betree
Copy link
Member Author

Betree commented Oct 4, 2021

@Deep1Shikha This issue lacks some comprehensive specs, and I would like us to think a bit more about it since we recently introduced #3689 which is kind of related.
I can recommend looking at one of these issues instead: https://github.com/opencollective/opencollective/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@alanna alanna added the bounty candidate Potential bounty, to be reviewed. Having this tag on an issue does not qualify it for a bounty. label Mar 29, 2022
@Betree
Copy link
Member Author

Betree commented Apr 13, 2022

Stripe has this interesting onboarding step:

image

@Betree
Copy link
Member Author

Betree commented Feb 2, 2023

Note: PayPal has a soft_descriptor option (max length 22) for this

@hdiniz
Copy link

hdiniz commented Feb 8, 2023

Stripe also has this option on a payment intent basis:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) bounty candidate Potential bounty, to be reviewed. Having this tag on an issue does not qualify it for a bounty. complexity → simple feature stale
Projects
None yet
Development

No branches or pull requests

5 participants