Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce limit in all GraphQL collection resolvers #4585

Closed
Betree opened this issue Aug 26, 2021 · 0 comments · Fixed by opencollective/opencollective-api#6522
Closed

Enforce limit in all GraphQL collection resolvers #4585

Betree opened this issue Aug 26, 2021 · 0 comments · Fixed by opencollective/opencollective-api#6522
Assignees
@Betree
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) complexity → simple performance Load times, slow queries, overall execution speed technical-debt Deprecated code to migrate and other necessary refactors

Comments

@Betree
Copy link
Member

Betree commented Aug 26, 2021

Whenever we return a Collection in GraphQL V2, limit should be a GraphQLNonNull field with a reasonable default value.

In some places, we may also want to reject queries where limit is set to a value that is too high.
@Betree Betree added complexity → simple api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) technical-debt Deprecated code to migrate and other necessary refactors performance Load times, slow queries, overall execution speed labels Aug 26, 2021
This was referenced Aug 26, 2021
Open
Closed
@Betree Betree self-assigned this Aug 31, 2021
@Betree Betree mentioned this issue Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Betree Betree

Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) complexity → simple performance Load times, slow queries, overall execution speed technical-debt Deprecated code to migrate and other necessary refactors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GQLV2: Enforce pagination on collections opencollective/opencollective-api
1 participant
@Betree