feat: Add new Admin Panel #6881
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). opencollective-frontend – ./🔍 Inspect: https://vercel.com/opencollective/opencollective-frontend/DKF6JmAA752rjbgxv3TDJhDb5knD opencollective-styleguide – ./🔍 Inspect: https://vercel.com/opencollective/opencollective-styleguide/EseG7RR6dEV7qix12u4s8SdWw5Yw |
| { | ||
| display: 'flex', | ||
| }, | ||
| compose(space, layout, flexbox), |
There was a problem hiding this comment.
I personally liked that we matched the original behavior of the rebass/grid library, and that we're keeping it simple. Why not use the Container, which supports all these?
There was a problem hiding this comment.
I don't think we were matching the rebass behavior. I'm pretty much sure you can pass alignItems="center" overflow="hidden" props in rebass.
I'll refactor this to use Container.
There was a problem hiding this comment.
It matches the rebass behavior from when we removed the dependency. This file was initially just a copy-paste of https://github.com/rebassjs/grid/blob/master/src/index.js
There was a problem hiding this comment.
Isn't it weird that a div Flex component accepts no CSS flex or div properties?
There was a problem hiding this comment.
@kewitz It does accept CSS flex properties already, since it inherits Box which implements styled-system's flexbox. Actually, the properties that you added there are already supported by the component.
lang/en.json
Outdated
| "AdminPanel.CollectiveSettings": "Collective Settings", | ||
| "AdminPanel.FiscalHostSettings": "Fiscal Host Settings", | ||
| "AdminPanel.HostDashboard": "Host Dashboard", | ||
| "AdminPanel.Menu.BudgetManagement": "Overview", | ||
| "AdminPanel.Menu.Collectives": "Collectives", | ||
| "AdminPanel.Menu.Expenses": "Expenses", | ||
| "AdminPanel.Menu.FinancialContributions": "Financial Contributions", | ||
| "AdminPanel.Menu.HostedCollectives": "Hosted Collectives", | ||
| "AdminPanel.Menu.Overview": "Overview", | ||
| "AdminPanel.Menu.PendingApplications": "Pending Applications", | ||
| "AdminPanel.Menu.Reports": "Reports", | ||
| "AdminPanel.OrganizationSettings": "Organization Settings", | ||
| "AdminPanel.Settings": "Settings", | ||
| "AdminPanel.Settings.Updated": "Settings updated.", |
There was a problem hiding this comment.
Some duplicated strings in there (eg. Financial Contributions)
kewitz
force-pushed
the
feat/admin-panel
branch
from
dc6c161
to
9dcaec6
Compare
kewitz
force-pushed
the
feat/admin-panel
branch
from
9dcaec6
to
10f672c
Compare
There was a problem hiding this comment.
The mobile version feels fantastic ✨ Some feedback below, but I think we're mostly good for internal testing.
/betree/adminturns out empty when accessed directly
When accessed via URL, it works but the menu entry is not selected:
-
When I'm on a user profile, is should say
User settingsnotCollective settings
-
When I click the cog icon for a collective, I see this message flashing (~1s) before the page appears. It's probably displayed while fetching, since it appears longer for large hosts on staging
- 🍨 Personal opinion: when you click on "Back" there, it should close the sub-section you're currently looking at and go back to the default one
Co-authored-by: Benjamin Piouffle <benjamin@opencollective.com>
Co-authored-by: Benjamin Piouffle <benjamin@opencollective.com>
Co-authored-by: Benjamin Piouffle <benjamin@opencollective.com>
Co-authored-by: Benjamin Piouffle <benjamin@opencollective.com>
Resolves opencollective/opencollective#4693
:slug/adminpageThis is still not the default settings menu, you'll need to add
/adminat the end of your collective URL to access it.