Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root admin action to change the status of a tax form #4805

Closed
alanna opened this issue Oct 8, 2021 · 7 comments · Fixed by opencollective/opencollective-frontend#8735
Closed
Assignees
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) complexity → simple feature frontend

Comments

@alanna
Copy link
Contributor

alanna commented Oct 8, 2021

User story

As a platform admin, I want to update the status of users' tax forms myself, so we don't have to ask a dev each time we have to process one manually, and to enable faster unblocking for users held up by a tax form status issue.

Best solution for this problem

Add a 'tax form' section to root admin dashboard, where you can select a user profile and change between statuses (not requested, requested, received - or whatever they are called)

@Betree WDYT?

@alanna alanna added the feature label Oct 8, 2021
@Betree Betree added api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) complexity → simple frontend labels Oct 12, 2021
@Betree
Copy link
Member

Betree commented Oct 12, 2021

Sounds good, I would also add an input for the document link as it's important we keep storing them

@Betree
Copy link
Member

Betree commented Mar 21, 2022

Looking back at this one I think we should add this feature directly into the interface, on the "Tax form required" message. A simple button like "Mark as received" would open a modal with an input for the document link.

@Betree Betree changed the title Add tax form status change to root admin dashboard Ability for host admins to change the status of a tax form Mar 21, 2022
@alanna
Copy link
Contributor Author

alanna commented Jul 25, 2022

Ideally this would also include a way to upload the form itself (received manually) to the right place in storage with the other tax forms

@BenJam BenJam changed the title Ability for host admins to change the status of a tax form Change the status of a tax form Aug 25, 2022
@znarf znarf added this to the Support & Operations milestone Sep 15, 2022
@Betree Betree changed the title Change the status of a tax form Root admin action to change the status of a tax form Sep 15, 2022
@SudharakaP
Copy link
Member

Looking back at this one I think we should add this feature directly into the interface, on the "Tax form required" message. A simple button like "Mark as received" would open a modal with an input for the document link.

@Betree : Only issue I have here is the placement of the button. Are we good to add it on the tax form warning message itself?

image

  • This would only be shown to host admins.
  • Once clicked we open a modal with field to add the link.

@Betree
Copy link
Member

Betree commented Mar 6, 2023

Once clicked we open a modal with field to add the link.

Is it the responsibility of the host admin to find this link and set it? We already have it in the database, why not send it directly?

@SudharakaP
Copy link
Member

Once clicked we open a modal with field to add the link.

Is it the responsibility of the host admin to find this link and set it? We already have it in the database, why not send it directly?

My understanding here is that the host admin will have the tax file; they first go to Google Drive (which we currently use) and upload it to the tax folder. Then copy the link from there and set it on the modal here. Are you suggesting that a dev does the link update in the db and the the host admin just changes the status?

@Betree
Copy link
Member

Betree commented Mar 7, 2023

@SudharakaP Oh my bad, I thought this was the issue about being able to re-send tax forms request emails (#6126). Your proposal sounds good then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) complexity → simple feature frontend
Development

Successfully merging a pull request may close this issue.

4 participants